Support text elements in figure container. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly for mpld3, exporting figure-level text objects (such as fig.suptitle) would never get exported. It looks like figure-level text objects (and objects in general) was completely missing here. This adds text objects, I might add more in the future. The alternative was to put figure text objects into the first axis object, but that's extremely hacky, so I went for the larger but proper fix instead. I did this together with gpt-5.1-codex, not alone. Here is what it has to say: - Exporter now emits figure-level text (suptitle + fig.text) via a dedicated draw_figure_text call before crawling axes; figure transforms passed directly to process_transform instead of shoving text into the first axes. - Renderer API gains a draw_figure_text hook (no-op default in base) so non-mpld3 renderers don’t break; FakeRenderer already implements it. - Figure JSON now carries a texts array and MPLD3Renderer serializes figure-level text entries with proper coordinates/attrs; tests cover presence/positions of exported figure texts.
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Nov 28, 2025
This fixes issues such as mpld3#296 and maybe more, about figure-level text (such as fig.suptitle) not appearing. It requires the corresponding mplexporter PR to land first, and only then I should also update the submodule commit to that here: mpld3/mplexporter#70 It also sets up support for figure-level transforms, which we'll need to support more figure-level objects in the future. I put the compiled js files in a separate commit for ease of reviewing. This, too, was co-developed with gpt-5.1-codex, but I was heavily involved. Here is how it summarizes the changes: - Export figure-level text (suptitle + fig.text) into the mpld3 figure JSON (texts array) via the vendored exporter/renderer, rather than shoving it into an axes. - JS core updated to handle figure-level coordinates/text: Coordinates can work with a figure, Figure renders figuretexts into a dedicated group, and Text can draw without an axes. - Added tests asserting figure-level texts are exported and included in the figure dict; rebuilt the JS bundle accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for mpld3, exporting figure-level text objects (such as fig.suptitle) would never get exported. It looks like figure-level text objects (and objects in general) was completely missing here. This adds text objects, I might add more in the future.
The alternative was to put figure text objects into the first axis object, but that's extremely hacky, so I went for the larger but proper fix instead.
It will fix this issue: mpld3/mpld3#296 (comment)
I did this together with gpt-5.1-codex, not alone. Here is what it has to say: